Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field to pass additional arguments to the node plugin #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

l0wl3vel
Copy link

@l0wl3vel l0wl3vel commented Apr 1, 2023

Allows to use the helm chart with encrypted volumes without having to manually patch the Daemonset.

l0wl3vel added a commit to l0wl3vel/juicefs-csi-driver that referenced this pull request Apr 1, 2023
@zwwhdls
Copy link
Member

zwwhdls commented Apr 3, 2023

Hi @l0wl3vel , thanks for your contributions, we are so appreciative for it. But format-in-pod is deprecated and this behavior(format in initContainer of mount pod) is set by default. Can you take other parameters such as reconciler-interval=5 for example?

@zwwhdls
Copy link
Member

zwwhdls commented Apr 21, 2023

Hi @l0wl3vel , can you fix the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants