cmd/mount: service process notifies the daemon via a signal that the mount point is ready #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
===========================================
- Coverage 54.78% 21.47% -33.32%
===========================================
Files 166 29 -137
Lines 48431 19187 -29244
===========================================
- Hits 26534 4120 -22414
+ Misses 18994 14576 -4418
+ Partials 2903 491 -2412 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jiefenghuang <[email protected]>
jiefenghuang
changed the title
jiefenghuang
approved these changes
Feb 8, 2025
Signed-off-by: jiefenghuang <[email protected]>
davies
reviewed
Feb 10, 2025
| if err != nil { | ||
| return fmt.Errorf("get original mount client pid error: %s", err) | ||
| } | ||
| if err = syscall.Kill(pid, syscall.SIGUSR1); err != nil { |
There was a problem hiding this comment.
this mount point is not ready at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5619