Use '--yes' and 'check_call' instead of 'Popen' and 'communicate'.

juju · Sep 3, 2021 · 61244f6 · 61244f6
1 parent 4af0d14
commit 61244f6
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/charmhelpers/contrib/storage/linux/lvm.py b/charmhelpers/contrib/storage/linux/lvm.py
@@ -58,9 +58,7 @@ def remove_lvm_physical_volume(block_device):
 
     :param block_device: str: Full path of block device to scrub.
     '''
-    p = Popen(['pvremove', '-ff', block_device],
-              stdin=PIPE)
-    p.communicate(input=b'y\n')
+    check_call(['pvremove', '-ff', '--yes', block_device])
 
 
 def list_lvm_volume_group(block_device):