Expose code coverage #173
Merged
Expose code coverage #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes code coverage so that we can provide analysis on it later.
|
I'm happy for us to do this conceptually, I think it is good for us. Does this cause problems with overhead/causes borderline tests to start to fail? Should we be targeting 3.4 for this as well? |
|
@jameinel I want to see how much it costs us first, we might have to move this somewhere else if it is expensive to run. |
jack-w-shaw
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
As we can see from runs like:
https://jenkins.juju.canonical.com/job/github-make-check-juju/11737/
Adding these coverage reports has a negligible cost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes code coverage so that we can provide analysis on it later.