Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-version for packaging source #178

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

SimonRichardson
Copy link
Member

We're getting failures because the older version of the go compiler didn't understand patch versions in the go.mod directive.

See:

06:14:36 /home/jenkins/workspace/package-juju-source/build/src/github.com/juju/juju/go.mod:3: invalid go version '1.21.6': must match format 1.23
06:14:36 make: *** [Makefile:521: vendor-dependencies] Error 1

@SimonRichardson SimonRichardson self-assigned this Mar 18, 2024
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should really be using the go version detection stuff, but this will do for now.

@@ -124,7 +124,7 @@
fi

export PATH="/snap/bin:$PATH"
sudo snap refresh go --channel=1.17/stable || sudo snap install go --channel=1.17/stable --classic
sudo snap refresh go --channel=1.21/stable || sudo snap install go --channel=1.21/stable --classic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.22 surely?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just matching main.

@SimonRichardson SimonRichardson merged commit a5bdb76 into juju:main Mar 18, 2024
1 of 2 checks passed
@SimonRichardson SimonRichardson deleted the update-package-source branch March 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants