Skip to content

feat(application): deploy applications with custom resources #68

feat(application): deploy applications with custom resources

feat(application): deploy applications with custom resources #68

Re-run triggered August 6, 2024 16:12
Status Failure
Total duration 23s
Artifacts

static-analysis.yaml

on: pull_request
Check conventional commits
13s
Check conventional commits
Fit to window
Zoom out
Zoom in

Annotations

1 error
Check conventional commits
You have commit messages with errors ⧗ input: feat(application): Deploy applications with custom resources - This commit defines ResourceHttpClient to upload custom OCI resources to Juju controller. - `addPendingResources` function is modified to upload custom resources. - Application is deployed using custom resources. docs(application): Application markdown file is modified to update `resources` description of application definition in the TF plan. IMPORTANT: Application input resources are changed from map[string]int to resources map[string]string. Signed-off-by: gatici <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: feat(application): Update custom images when application is updated This commit updates the application resources after the application is deployed using a custom OCI resource when TF plan resources are updated. tests(resource): UploadPendingResource mock base method is generated. Signed-off-by: gatici <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: feature(application): Remove resorces when the plan does not specify resource If the application is deployed with specified resources such as revision numbers from CharmHub or an OCI image, then the resources are removed from the TF plan, the default resources from the CharmHub is used. test(resources): Adding tests for new functions that added for custom resource upload docs(application): Updating application resources map description in the application markdown file Signed-off-by: gatici <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum] ✖ found 3 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: feature(resources): Address review comments to update to latest resource revision upon channel updates If the charm channel is updated and revision or custom image is not specified in the TF plan, a resource revision should be attached according the updated channel. Formerly, this functionality is not implemented properly. This commit implements this. revert: Unncessary resource files added for testing are removed. chore: Some libraries are updated in go.mod and go.sum. Linting issues are fixed. docs(resources): Documentation is updated for `resources` key to include added functionality. Signed-off-by: gatici <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ header must not be longer than 100 characters, current length is 102 [header-max-length] ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum] ✖ found 4 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: revert(docs): Removing additional example from resource.tf In the previous commits, a new sample TF plan was added to show the usage of custom resources. This commits reverts this change by adding combining the placement and resource usage example in the same existing TF plan. Signed-off-by: gatici <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ subject must not be sentence-cas