-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-6244 Adds client ID and secret to the provider config. #424
Conversation
a8fe4bc
to
a8f02a3
Compare
a8f02a3
to
bea5178
Compare
bea5178
to
cd74380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file: https://github.com/juju/terraform-provider-juju/blob/main/templates/index.md.tmpl needs updates to Authentication section related to this change. After run make docs
to add the results.
The PR description has no QA steps.
Have you run the acceptance tests locally? Github is consistently getting failures on the lxd tests.
ba8ac13
to
c86efa6
Compare
83743e1
to
1b8512d
Compare
This change will allow for authentication using client ID and secret when connecting to JAAS. Updates Juju dependency to 3.5 that contains needed login changes.
1b8512d
to
efba6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just completed manual QA against 3.4
and 3.5
and it went well, everything seems to be working fine.
I was able to provide and pass through the client_id
and the client_secret
just fine, and also the validation against mutual exclusivity with username/password
seems to be working fine.
Though I couldn't test it against a real JAAS setup with Juju, I'll give it a green light, as i) I confirmed that the current functionality is working without any issues, ii) all the tests are passing, and iii) I imagine @alesstimec can confirm that it's working well on jaas as he's the one who needed this change in the first place.
Description
Added client ID and client secret to Juju provider config, which will allow terraform provider to log in to JAAS using these client credentials.
Updates Juju dependency to 3.5 that contains needed login changes.
Type of change
<What type of a change is this? Please keep one or more relevant lines from below and delete the others.>
Environment
Juju controller version: 3.5
Terraform version:
QA steps
Manual QA steps should be done to test this PR.
Additional notes
<Please add relevant notes & information, links to mattermost chats, other related issues/PRs, anything to help understand and QA the PR.>