Handle race where offer is already destroyed #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an offer has already been destroyed, 'DestroyOffer' will fail with a 'not found' error. In this case, there is no offer to destroy, so we should just return successfully. This race is rare, but has been seen here: https://github.com/juju/juju/actions/runs/7745564317/job/21121856659?pr=16883
hmlanigan
requested changes
Apr 10, 2024
| @@ -192,6 +193,10 @@ func (c offersClient) DestroyOffer(input *DestroyOfferInput) error { | |||
|
|
|||
| client := applicationoffers.NewClient(conn) | |||
| offer, err := client.ApplicationOffer(input.OfferURL) | |||
| if jujuerrors.Is(err, jujuerrors.NotFound) { | |||
There was a problem hiding this comment.
We don't get actual types out of the juju clients usually. Check out some of the other NotFound code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an offer has already been destroyed, 'DestroyOffer' will fail with a 'not found' error. In this case, there is no offer to destroy, so we should just return successfully.
This race is rare, but has been seen here:
https://github.com/juju/juju/actions/runs/7745564317/job/21121856659?pr=16883
Fixes: #395
Type of change
Environment
Juju controller version: I'm using 3.4, since the bug this addresses was seen in 3.4
Terraform version: 1.7.5
QA steps