Assign non-empty client_id to username
#475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <[email protected]>
hmlanigan
requested changes
Apr 30, 2024
|
The plan is to fix this in juju 3.5.1 apis, then once released pull into the next terraform release. 3.5.1 is planned for 10-Jun. The juju pr to fix is: juju/juju#17309 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While QA-ing the
rc0.12.0, we noticed an error complaining about emptyusernamefield. Actually, when theclient_idis already assigned, theusernamehas to be empty, and there should be no error. In this PR,usernameis assigned to theclient_idvalue, whenever theclient_idis not empty.Fixes:
Type of change
Environment
Juju controller version: 3.5-rc1
Terraform version: 1.8.2-dev