Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): fix goreleaser configuration to comply with version 2 #529

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

cderici
Copy link

@cderici cderici commented Jul 22, 2024

Description

It looks like a while ago dependabot changed the uses: goreleaser/goreleaser-action@v5 -> uses: goreleaser/goreleaser-action@v6, which apparently uses goreleaser v2. And because of that the release github action is failing on the v0.13.0 release.

This updates the goreleaser configuration based on the deprecation notices for v2.

Basically the main change is the changelog skip.

Type of change

  • Maintenance work (repository related, like Github actions, or revving the Go version, etc.)

QA steps

Manual QA steps should be done to test this PR.

 $ snap install goreleaser --classic
 $ goreleaser check

Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update for this one while we're looking at it: https://goreleaser.com/deprecations/#builds-for-darwinarm64

You can replace the Darwin/386 with Darwin/arm64, line 35 and remove the commented lines of 27, 28.

@cderici cderici merged commit 0ff24d1 into juju:main Jul 22, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants