feat: add jaas client #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
CSS-9773-add-jaas-client
branch
from
7c97c25 to
5e8e75e
Compare
alesstimec
reviewed
Aug 6, 2024
hmlanigan
requested changes
Aug 6, 2024
kian99
force-pushed
the
CSS-9773-add-jaas-client
branch
from
36a5d48 to
d2dd485
Compare
kian99
force-pushed
the
CSS-9773-add-jaas-client
branch
2 times, most recently
from
4d78efb to
dc25c74
Compare
hmlanigan
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
With one nit, I'm happy with the changes.
@alesstimec are you happy with the changes?
alesstimec
approved these changes
Aug 16, 2024
|
|
||
| type jaasClient struct { | ||
| SharedClient | ||
| getJaasApiClient func(jujuapi.Connection) JaasAPIClient |
There was a problem hiding this comment.
nitpick: we could call this newAPIClient.. we know it's a JAAS api client as it is a method of the jaasClient
There was a problem hiding this comment.
It's at least in line with the naming style used for the other clients, but I see your point.
- Don't leak api types outside of the jaas client. - Cleanup tests
Updated godocs
kian99
force-pushed
the
CSS-9773-add-jaas-client
branch
from
e356153 to
960de19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the JAAS client to the provider. A full list of changes:
jimm-go-sdkmodule that provides the client.jimm-go-sdkcurrently has a dependency on Juju 3.5.3 which Go bumps to when runninggo get github.com/canonical/jimm-go-sdk/v3jaas.gofile ininternal/jujuwhich contains the client code. The only methods are a read/add/delete relations.internal/juju/jaas_test.gowhich uses GoMock like the tests forsecrets.go.I recommend reviewing per PR to view the implementation and tests separately.
Type of change
internal/juju/.Additional notes
Resolves https://warthogs.atlassian.net/browse/CSS-9773