feat: jaas integration tests #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hmlanigan This PR and #552 are ready for review, the only blocker on the JAAS integration tests is that we are waiting on the JIMM repo to be made public which should be done on Monday. |
kian99
force-pushed
the
CSS-6347-jaas-integration-tests
branch
2 times, most recently
from
98b621f to
5681284
Compare
kian99
force-pushed
the
CSS-6347-jaas-integration-tests
branch
4 times, most recently
from
f024791 to
52cab76
Compare
hmlanigan
reviewed
Sep 3, 2024
| jimm-version: v3.1.8 | ||
| juju-channel: 3/stable | ||
| ghcr-pat: ${{ secrets.GHCR_JAAS_PAT }} | ||
| # TODO(Kian): Verify whether this is needed. |
There was a problem hiding this comment.
question: where is the version of lxd being used configured?
There was a problem hiding this comment.
It's currently a fixed version of LXD in the JIMM-setup action with "5.19/stable"
kian99
force-pushed
the
CSS-6347-jaas-integration-tests
branch
2 times, most recently
from
9d4a09b to
6eee13c
Compare
- Add workflow to start JAAS and run tests. - Add logic to skip tests that are not appropriate for JAAS.
kian99
force-pushed
the
CSS-6347-jaas-integration-tests
branch
from
6eee13c to
32ad8f0
Compare
|
@hmlanigan tests are now passing. Two notes,
|
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration test workflow to test the provider against a JIMM controller.
The full list of changes include:
Fixes: CSS-6347
Type of change
Additional notes
The Github action at
canonical/jimm/.github/action/test-serveris ready but because thecanonical/jimmrepo is not public, it is not accessible. The repo will become public very early next week. Marking this PR as a draft until then.