Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "avoid jaas" validator to existing resources #569

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Sep 10, 2024

Description

This PR adds "Avoid JAAS" validator to all resources that cannot be used with JAAS. Specifically:

  • Ensure certain resources cannot be used with JAAS and add tests for this.
  • Tweak the error messaging based on previous feedback in this discussion.

Fixes: CSS-10238

Type of change

  • Logic changes in resources (additional validation for JAAS)

@kian99 kian99 requested a review from hmlanigan September 10, 2024 13:55
internal/juju/client.go Outdated Show resolved Hide resolved
@kian99 kian99 force-pushed the CSS-10238-add-jaas-validators branch from 972b26a to 902d587 Compare September 12, 2024 06:51
@kian99 kian99 requested a review from hmlanigan September 12, 2024 07:00
- Ensure certain resources cannot be used with JAAS and add tests for this.
- Tweak the error messaging based on previous feedback.
- Add constructors for JAAS validators.
@kian99 kian99 force-pushed the CSS-10238-add-jaas-validators branch from 902d587 to d8757a0 Compare September 13, 2024 08:39
@hmlanigan hmlanigan merged commit d9920f1 into juju:jaas-resources Sep 13, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants