add JAAS cloud access resource #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename genericJAASAccessModel to genericJAASAccessData to avoid overloading the word model - Remove AtLeastOneOf validator to allow users to remove all direct access to a resource. - Add test helper functions
- Add model access test that includes a user, group and service account.
kian99
changed the title
kian99
changed the title
hmlanigan
reviewed
Sep 19, 2024
Comment on lines
87
to
91
| resourcevalidator.AtLeastOneOf( | ||
| path.MatchRoot("users"), | ||
| path.MatchRoot("groups"), | ||
| path.MatchRoot("service_accounts"), | ||
| ), |
There was a problem hiding this comment.
question:
Remove AtLeastOneOf validator to allow users to remove all direct access to a resource.
Why leave a resource with no content essentially? Wouldn't the resource just be deleted from the plan? Essentially, why would someone bother?
There was a problem hiding this comment.
Yes good point, I had a silly moment thinking it would be good to give the user the ability to remove all access but as you said, that's the same as deleting the resource. I've reverted this and fixed the test.
kian99
force-pushed
the
CSS-10638-remaining-jaas-resources
branch
from
69fe8ed to
2522110
Compare
kian99
force-pushed
the
CSS-10638-remaining-jaas-resources
branch
from
2522110 to
04b134e
Compare
This was referenced Sep 20, 2024
|
/merge |
jujubot
added a commit
that referenced
this pull request
Sep 24, 2024
#584 ## Description This PR adds a new resource `juju_jaas_access_offer` building on top of the generic access structure. Note that there is a minor issue with Juju application offer tags. In the Juju names/v4 package, an `applicationoffer` tag was based on an offer URL. In the names/v5 package this changed to an offer UUID. JAAS accepts both but currently the provider does not store the offer UUID (proposed change in #583). Until then I've opted to use the Juju names/v4 package to construct application offers based on an offer URL. This PR is based on top of #581. See the last commit for the changes. Partially resolves: [CSS-10638](https://warthogs.atlassian.net/browse/CSS-10638) ## Type of change - Add new resource [CSS-10638]: https://warthogs.atlassian.net/browse/CSS-10638?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new resource
juju_jaas_access_cloudbuilding on top of the generic access structure. Note that in Juju clouds are a bit unique compared to models. Whereas model have a unique UUID, clouds do not and are unique based on the cloud name. Remaining resources for jaas_access includeapp-offers,controller,group,service-account. They will all follow the same structure and tests.The full list of changes include:
juju_jaas_access_cloudresource and tests.Partially resolves: CSS-10638
Type of change