feat(clouds): add initial implementation for clouds client #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvial
force-pushed
the
JUJU-6547-prepare-schema-form-cloud-resource
branch
from
249f5a7 to
b92dcc9
Compare
- Introduced `cloudsClient` struct with methods for creating, reading, updating, and destroying clouds. - Added input and output structs for `CreateCloud`, `ReadCloud`, `UpdateCloud`, and `DestroyCloud` operations. - Integrated `cloudsClient` with `SharedClient` for shared functionality. This change sets up the basic structure for managing clouds within the Juju client.
anvial
force-pushed
the
JUJU-6547-prepare-schema-form-cloud-resource
branch
from
b92dcc9 to
e8ac402
Compare
hmlanigan
reviewed
Sep 25, 2024
Update internal/provider/resource_kubernetes_cloud.go chore: extend cloud name description Co-authored-by: hmlanigan <[email protected]> Update internal/provider/resource_kubernetes_cloud.go chore: extend parent cloud name description Co-authored-by: hmlanigan <[email protected]> Update internal/provider/resource_kubernetes_cloud.go chore: extend parent cloud region description Co-authored-by: hmlanigan <[email protected]> chore: added method comment headers chore: added "id" to the schema to handle imports chore: delete test file (until it's used) chore: delete clouds_test unit it's used chore: remane cloudsClient --> kubernetesCloudClient
anvial
force-pushed
the
JUJU-6547-prepare-schema-form-cloud-resource
branch
from
a61410c to
c7d2617
Compare
hmlanigan
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
cloudsClientstruct with methods for creating, reading, updating, and destroying clouds.CreateCloud,ReadCloud,UpdateCloud, andDestroyCloudoperations.cloudsClientwithSharedClientfor shared functionality.This change sets up the basic structure for managing clouds within the Juju client.
Type of change
QA steps