WIP: Fix jaas integration test #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jaas integration tests were missing a change for how the microk8s.config is provided to the acceptance tests. Causing the add k8s cloud resource test to fail.
hmlanigan
force-pushed
the
fix-jaas-test
branch
from
006feec to
466784e
Compare
anvial
reviewed
Dec 4, 2024
| @@ -71,9 +71,6 @@ jobs: | |||
| sudo microk8s.enable dns storage | |||
| sudo microk8s.enable dns local-storage | |||
There was a problem hiding this comment.
Let's change this to:
sudo microk8s enable hostpath-storage
sudo microk8s enable dns
anvial
reviewed
Dec 4, 2024
| if: ${{ matrix.action-operator.cloud == 'lxd' }} | ||
| # language=bash | ||
| run: | | ||
| sudo microk8s.config > /home/$USER/microk8s-config.yaml |
There was a problem hiding this comment.
Something wrong with StdOut forwarding here. Try:
sudo microk8s.config | tee /home/$USER/microk8s-config.yaml
that should help
|
/merge |
|
this work is getting picked up in #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update how microk8s.config is provided to the tests to allow the TestAcc_ResourceKubernetesCloud to run.
Type of change
QA steps
In the Integration-JAAS action, TestAcc_ResourceKubernetesCloud should not fail due to lack of micrko8s config.