fix - remove force destroy of application offers. #651
Conversation
alesstimec
force-pushed
the
fix-force-remove-offer
branch
from
bd7ac67 to
2a13a5a
Compare
internal/juju/offers.go
Outdated
| for ok := true; ok; ok = len(offer.Connections) > 0 { | ||
| //if we have been failing to destroy offer for 5 minutes then fail on destroy | ||
| if time.Now().After(end) { | ||
| return fmt.Errorf("offer %q has remaining connections", input.OfferURL) |
There was a problem hiding this comment.
possibly add to the log the remaining connections, so a final user can debug it/file a more precise bug report
There was a problem hiding this comment.
@SimoneDutto good idea, I suggest different output though. Not all users will understand connections.
RelationID would be ideal, but the provider doesn't deal in RelationIDs like the juju cli does.
Let's try offer.SourceModelUID and offer.Endpoint in the message. It should have the application:relation in the string. That should be enough info to find the relation causing the issue.
There was a problem hiding this comment.
todo: update the commit message and pr description to include why this is being done.
=== CONT TestAcc_ResourceIntegrationWithMultipleConsumers
resource_integration_test.go:222: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Client Error
Unable to delete offer, got error: offer
"admin/tf-test-integration-6969741932116347544.a" has remaining connections
--- FAIL: TestAcc_ResourceIntegrationWithMultipleConsumers (382.32s)
are directly related to this change. It's a racey test now.
internal/juju/offers.go
Outdated
| for ok := true; ok; ok = len(offer.Connections) > 0 { | ||
| //if we have been failing to destroy offer for 5 minutes then fail on destroy | ||
| if time.Now().After(end) { | ||
| return fmt.Errorf("offer %q has remaining connections", input.OfferURL) |
There was a problem hiding this comment.
@SimoneDutto good idea, I suggest different output though. Not all users will understand connections.
RelationID would be ideal, but the provider doesn't deal in RelationIDs like the juju cli does.
Let's try offer.SourceModelUID and offer.Endpoint in the message. It should have the application:relation in the string. That should be enough info to find the relation causing the issue.
alesstimec
force-pushed
the
fix-force-remove-offer
branch
2 times, most recently
from
56970eb to
cfab456
Compare
Removes force removal of application offers, but rather errors out if there are existing integrations with the offer that must be removed first. This is a much cleaner way to destroy offers as the use of the `force` flag may leave the Juju state with leftover artefacts.
alesstimec
force-pushed
the
fix-force-remove-offer
branch
from
cfab456 to
b734312
Compare
Description
Removes force removal of application offers.
Fixes:
Type of change