Merge pull request #333 from julia-vscode/sp/large-file-limit

Large file limits for linting
julia-vscode · Sep 18, 2023 · 299cb3b · 299cb3b
2 parents 5fb681c + c4a3032
commit 299cb3b
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 5 deletions.
diff --git a/src/StaticLint.jl b/src/StaticLint.jl
@@ -17,6 +17,8 @@ include("scope.jl")
 include("subtypes.jl")
 include("methodmatching.jl")
 
+const LARGE_FILE_LIMIT = 2_000_000 # bytes
+
 mutable struct Meta
     binding::Union{Nothing,Binding}
     scope::Union{Nothing,Scope}
@@ -227,6 +229,20 @@ function traverse(x::EXPR, state)
     end
 end
 
+function check_filesize(x, path)
+    nb = try
+        filesize(path)
+    catch
+        seterror!(x, FileNotAvailable)
+        return false
+    end
+
+    toobig = nb > LARGE_FILE_LIMIT
+    if toobig
+        seterror!(x, FileTooBig)
+    end
+    return !toobig
+end
 
 """
     followinclude(x, state)
@@ -245,7 +261,11 @@ function followinclude(x, state::State)
         elseif isabspath(path)
             if hasfile(state.server, path)
             elseif canloadfile(state.server, path)
-                loadfile(state.server, path)
+                if check_filesize(x, path)
+                    loadfile(state.server, path)
+                else
+                    return
+                end
             else
                 path = ""
             end
@@ -255,7 +275,11 @@ function followinclude(x, state::State)
                 path = joinpath(dirname(getpath(state.file)), path)
             elseif canloadfile(state.server, joinpath(dirname(getpath(state.file)), path))
                 path = joinpath(dirname(getpath(state.file)), path)
-                loadfile(state.server, path)
+                if check_filesize(x, path)
+                    loadfile(state.server, path)
+                else
+                    return
+                end
             else
                 path = ""
             end
@@ -277,8 +301,14 @@ function followinclude(x, state::State)
                 seterror!(x, IncludeLoop)
                 return
             end
+            f = getfile(state.server, path)
+
+            if f.cst.fullspan > LARGE_FILE_LIMIT
+                seterror!(x, FileTooBig)
+                return
+            end
             oldfile = state.file
-            state.file = getfile(state.server, path)
+            state.file = f
             push!(state.included_files, getpath(state.file))
             setroot(state.file, getroot(oldfile))
             setscope!(getcst(state.file), nothing)

diff --git a/src/linting/checks.jl b/src/linting/checks.jl
@@ -30,7 +30,9 @@
     CannotDefineFuncAlreadyHasValue,
     DuplicateFuncArgName,
     IncludePathContainsNULL,
-    IndexFromLength
+    IndexFromLength,
+    FileTooBig,
+    FileNotAvailable,
 )
 
 const LintCodeDescriptions = Dict{LintCodes,String}(
@@ -62,7 +64,9 @@ const LintCodeDescriptions = Dict{LintCodes,String}(
     CannotDefineFuncAlreadyHasValue => "Cannot define function ; it already has a value.",
     DuplicateFuncArgName => "Function argument name not unique.",
     IncludePathContainsNULL => "Cannot include file, path contains NULL characters.",
-    IndexFromLength => "Indexing with indices obtained from `length`, `size` etc is discouraged. Use `eachindex` or `axes` instead."
+    IndexFromLength => "Indexing with indices obtained from `length`, `size` etc is discouraged. Use `eachindex` or `axes` instead.",
+    FileTooBig => "File too big, not following include.",
+    FileNotAvailable => "File not available."
 )
 
 haserror(m::Meta) = m.error !== nothing