test: separate analysis and formatting, update naming

juliansteenbakker · Feb 4, 2025 · 8e92911 · 8e92911
1 parent 4fc0edb
commit 8e92911
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 15 deletions.
diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml
@@ -10,7 +10,7 @@ env:
 
 jobs:
   test_with_coverage:
-    name: 🧪 Run Flutter Unit Tests with Coverage
+    name: 🧪 Unit Tests
     runs-on: ubuntu-latest
     timeout-minutes: 20
     defaults:

diff --git a/.github/workflows/code-integration.yml b/.github/workflows/code-integration.yml
@@ -1,4 +1,4 @@
-name: 🤖📱 Code Integration
+name: 🤖📱 Code Integration Tests
 
 on:
   push:
@@ -15,7 +15,7 @@ defaults:
 jobs:
   # Android Integration Tests
   integration_tests_android:
-    name: 🤖 Android Integration Tests
+    name: 🤖 Android
     runs-on: ubuntu-latest
     timeout-minutes: 30
     steps:
@@ -43,7 +43,7 @@ jobs:
 
   # iOS Integration Tests
   integration_tests_ios:
-    name: 🍏 iOS Integration Tests
+    name: 🍏 iOS
     runs-on: macos-latest
     timeout-minutes: 30
     steps:

diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
@@ -13,27 +13,23 @@ env:
   PUB_ENVIRONMENT: bot.github
 
 jobs:
-  analysis_and_formatting:
-    name: 📝 Code Analysis & Formatting
+  analysis:
+    name: 🔍 Analysis
     runs-on: ubuntu-latest
 
     steps:
-      # Checkout the code
       - name: 📥 Checkout Code
         uses: actions/checkout@v4
 
-      # Set up Flutter
       - name: ⚡ Set Up Flutter
         uses: subosito/flutter-action@v2
         with:
           channel: stable
-          cache: true  # Enable Flutter SDK caching
+          cache: true
 
-      # Verify Flutter version
       - name: 🔍 Flutter Version Info
         run: flutter doctor -v
 
-      # Cache Pub dependencies
       - name: 📦 Cache Pub Dependencies
         uses: actions/cache@v3
         with:
@@ -44,20 +40,39 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-pub-
 
-      # Install Melos
       - name: 🚀 Install Melos
         run: |
           flutter pub global activate melos
           echo "$HOME/.pub-cache/bin" >> $GITHUB_PATH
 
-      # Bootstrap workspace
       - name: 🔧 Bootstrap Workspace with Melos
         run: melos bootstrap
 
-      # Run Linter
       - name: ✅ Lint Code
         run: melos analyze
 
-      # Check Code Formatting
+  formatting:
+    name: 🎨 Formatting
+    needs: analysis  # This makes formatting start after analysis is complete
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: 📥 Checkout Code
+        uses: actions/checkout@v4
+
+      - name: ⚡ Set Up Flutter
+        uses: subosito/flutter-action@v2
+        with:
+          channel: stable
+          cache: true
+
+      - name: 🚀 Install Melos
+        run: |
+          flutter pub global activate melos
+          echo "$HOME/.pub-cache/bin" >> $GITHUB_PATH
+
+      - name: 🔧 Bootstrap Workspace with Melos
+        run: melos bootstrap
+
       - name: 🎯 Check Code Formatting
         run: melos format --output none --set-exit-if-changed