Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add json feature for binlogevent #584

Merged
merged 5 commits into from
Dec 5, 2023
Merged

add json feature for binlogevent #584

merged 5 commits into from
Dec 5, 2023
+58 −1

Conversation

junha6316
Copy link
Contributor

@junha6316 junha6316 commented Dec 1, 2023 •
edited
Loading

Description

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please specify below)

Checklist

Tests

  • All tests have passed.
  • New tests have been added to cover the changes. (describe below if applicable).

Additional Information

@junha6316 junha6316 marked this pull request as ready for review December 1, 2023 07:46
sean-k1
sean-k1 reviewed Dec 1, 2023
View reviewed changes
pymysqlreplication/tests/test_event.py
"event_size",
"read_bytes"
]
target_fields = ["timestamp", "log_pos", "event_size", "read_bytes"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you put the target_field out of scope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just thought it can be reused when write other test case.

sean-k1
sean-k1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@sean-k1 sean-k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-k1 sean-k1 merged commit 78f9bf3 into julien-duponchelle:main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-k1 sean-k1 sean-k1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junha6316 @sean-k1