Fix incorrect operate test set
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 89.61% 89.65% +0.04%
==========================================
Files 23 23
Lines 2156 2156
==========================================
+ Hits 1932 1933 +1
+ Misses 224 223 -1 ☔ View full report in Codecov by Sentry. |
Currently the test set starts with the line
`@testset "$(typeof(x))" for x in [2, big(3)]`, which points to the
test not working as intended, because the array constructor
(`[2, big(3)]`) promotes all elements to a common type, so naming
the test set `"$(typeof(x))"` doesn't make sense.
Furthermore, after the above is fixed, the test fails because the `!==`
check is performed independently of whether the type is mutable.
TODO: including `Rational{BigInt}` among the tested types reveals what
seems to be a bug: #240.
TODO: including `abs` among the tested operations reveals that it lacks
an `operate` method: #241.
odow
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test set starts with the line
@testset "$(typeof(x))" for x in [2, big(3)], which points to the test not working as intended, because the array constructor ([2, big(3)]) promotes all elements to a common type, so naming the test set"$(typeof(x))"doesn't make sense.Furthermore, after the above is fixed, the test fails because the
!==check is performed independently of whether the type is mutable.TODO: including
Rational{BigInt}among the tested types reveals whatseems to be a bug: #240.
TODO: including
absamong the tested operations reveals that it lacksan
operatemethod: #241.