Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some methods for unary +, -, *, abs #245

Merged
merged 1 commit into from
Nov 30, 2023
Merged

add some methods for unary +, -, *, abs #245

merged 1 commit into from
Nov 30, 2023

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Nov 27, 2023

This is the first time that abs is implemented for BigInt and Rational.

Fixes #237.

@nsajko nsajko marked this pull request as draft November 27, 2023 03:52
@nsajko
Copy link
Contributor Author

nsajko commented Nov 27, 2023

Marking as draft until other PRs are merged.

@nsajko nsajko marked this pull request as ready for review November 28, 2023 17:06
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (444331d) 90.76% compared to head (3fb2ec5) 90.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   90.76%   90.95%   +0.18%     
==========================================
  Files          23       23              
  Lines        2122     2166      +44     
==========================================
+ Hits         1926     1970      +44     
  Misses        196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this open for a day or two in case @blegat wants to take a look, but LGTM.

This is the first time that `abs` is implemented for `BigInt` and
`Rational`.

Fixes #237.
@odow odow merged commit 9b58a40 into jump-dev:master Nov 30, 2023
11 checks passed
@nsajko nsajko deleted the operate_to_unary branch November 30, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

unary operate_to! recurs without bound, until stack overflow
2 participants