Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix neutral_element for AbstractArrays #320

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix neutral_element for AbstractArrays #320

merged 2 commits into from
Jan 14, 2025

Conversation

odow
Copy link
Member

@odow odow commented Jan 13, 2025

Closes #318

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (a12311e) to head (ecdd5c5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   90.29%   90.30%           
=======================================
  Files          22       22           
  Lines        2237     2238    +1     
=======================================
+ Hits         2020     2021    +1     
  Misses        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Jan 13, 2025

Something's up:

(base) oscar@MacBookPro MutableArithmetics % git push
remote: Internal Server Error
fatal: unable to access 'https://github.com/jump-dev/MutableArithmetics.jl.git/': The requested URL returned error: 500
(base) oscar@MacBookPro MutableArithmetics % git push
fatal: unable to access 'https://github.com/jump-dev/MutableArithmetics.jl.git/': Failed to connect to github.com port 443 after 2570 ms: Couldn't connect to server
(base) oscar@MacBookPro MutableArithmetics % git push
fatal: unable to access 'https://github.com/jump-dev/MutableArithmetics.jl.git/': The requested URL returned error: 502

@odow odow merged commit 33e5c64 into master Jan 14, 2025
10 of 11 checks passed
@odow odow deleted the od/neutral branch January 14, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dot product fails when the result is a matrix
1 participant