fix: If NA, return 0 locked apps (#32)

jumpingrivers · Jan 24, 2024 · bc44d57 · bc44d57
1 parent b408b2f
commit bc44d57
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: audit.connect
 Title: Posit Connect Health Check
-Version: 0.7.1
+Version: 0.7.2
 Authors@R:
     person("Jumping", "Rivers", , "[email protected]", role = c("aut", "cre"))
 Description: Posit Connect Health Check. Deploys various content types to

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+# audit.connect 0.7.2 _2024-01-24_
+  - fix: If NA, return 0 locked apps
+
 # audit.connect 0.7.1 _2023-12-05_
   - fix: If plumber deployment fails, handle failure gracefully
 

diff --git a/R/quarto-helpers.R b/R/quarto-helpers.R
@@ -45,6 +45,7 @@ get_quarto_user_roles = function(out) {
 #' @export
 get_quarto_locked_user_apps = function(out) {
   apps = out$users_details$apps
+  if (is.na(apps)) return(0L)
 
   app_creators =  purrr::map_df(apps,
                                 ~dplyr::tibble(owner = .x[["owner_username"]],

diff --git a/R/summarise_users.R b/R/summarise_users.R
@@ -9,6 +9,8 @@ summarise_users = function(server, token, debug_level) {
   user_list$users = suppress(connectapi::get_users(client, limit = Inf))
   user_list$users$url = paste0(server, "connect/#/people/users/", user_list$users$guid)
 
+  # XXX: I don't think this is right
+  # Evaluation copies should have apps???
   if (is_evaluation(settings)) {
     apps = NA
   } else {