Fix #14

NEWS.md

@@ -3,6 +3,7 @@
   * Improved `plot()` logic for the log scale
   * Conditionally use {vdiffr} for testing (CRAN request)
   * Bug: plot matrices fixes #13 (thanks to @gmonaie)
+  * BUg: barplot and axisnames. Fixes #14 (thanks to @yikeshu0611)
 
 ## Version 0.2.1
   * Bug fix: Don't open plotting window when loading the package

R/barplot.R

@@ -26,8 +26,6 @@ barplot.prettyB = function(height, width = 1, space = NULL, names.arg = NULL,
                            cex.names = par("cex.axis"), inside = TRUE,
                            plot = TRUE, axis.lty = 0, offset = 0,
                            add = FALSE, args.legend = NULL, ...) {
-  # op = set_par_minimal()
-  # on.exit(par(op))
   setup_prettyB()
 
   # Unchanged Arguments
@@ -124,10 +122,10 @@ barplot.prettyB = function(height, width = 1, space = NULL, names.arg = NULL,
 
   if (isTRUE(args$horiz)) {
     add_x_axis(ticks_x, tick = FALSE)
-    add_y_axis(lab_loc, labels = lab, tick = FALSE)
+    if (isTRUE(axisnames)) add_y_axis(lab_loc, labels = lab, tick = FALSE)
   } else {
     add_y_axis(ticks_y, tick = FALSE)
-    add_x_axis(lab_loc, labels = lab, tick = FALSE)
+    if (isTRUE(axisnames)) add_x_axis(lab_loc, labels = lab, tick = FALSE)
   }
   add_title(main)
   add_sub(sub)

R/par.R

@@ -1,4 +1,4 @@
-#' @title Set up par and palette
+#' Set up par and palette
 #'
 #' Sets up par and palette
 #' @export

tests/testthat/test_barplot.R

@@ -11,4 +11,6 @@ test_that("Testing barplot", {
                               barplot_p(VADeaths, xlab = "X", ylab = "Y",
                                       main = "Main", sub = "Sub"))
 
+  expect_doppelganger("barplot basic no axisnames",
+                      barplot_p(VADeaths, axisnames = FALSE))
 })