Skip to content

Commit

Permalink
Update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@csgillespie
csgillespie committed May 17, 2019
1 parent c145a02 commit f085458
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Test environments
- local x86_64-pc-linux-gnu install, R 3.5.3
- local x86_64-pc-linux-gnu install, R 3.6.0
- R-hub ubuntu-gcc-release (r-release)
- R-hub windows-x86_64-devel (r-devel)
- R-hub fedora-clang-devel (r-devel)
Expand All @@ -8,9 +8,6 @@

## R CMD check results

0 errors | 1 warnings | 1 note
0 errors | 0 warnings | 1 note

* Note: Previous version called par() onload. This have been removed.
* Warnings: Registered S3 methods from standard package(s) overwritten by 'prettyB':
- This package provides pretty versions of base graphics
- This is achieved by overwriting graphics::XXX.default functions

1 comment on commit f085458

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/testthat.R:6:3: style: Commented code should be removed.

​# vdiffr::manage_cases()
  ^~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test_boxplot.R:4:5: style: Use <-, not =, for assignment.

​  x = rlnorm(100)
    ^

tests/testthat/test_hist.R:4:5: style: Use <-, not =, for assignment.

​  x = rlnorm(100)
    ^

tests/testthat/test_plot.R:11:8: style: Use <-, not =, for assignment.

​    op = par(mfrow = c(1, 2))
       ^

tests/testthat/test_s3_plot.R:5:7: style: Use <-, not =, for assignment.

​    m = lm(1:10 ~ rnorm(10))
      ^

Please sign in to comment.