forked from mrc-ide/tfpscanner
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create html and rds treeviews by default #18
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f979d24
refac: rename treeview() param for specifying sina-plot output format
russHyde 475a98a
feat: save_trees() can output interactive trees to .rds or .html
russHyde 1b065ed
feat: treeview() outputs either .rds or .html (or both) for interacti…
russHyde e40dc26
feat: save_trees() can export html, rds or both for interactive plots
russHyde 8ddf13b
refac: simplify tests for filepaths created by save_trees()
russHyde 10979d7
chore: bump version
russHyde e2e0545
env: use htmlwidgets >= 1.6.0 to fix a bug with pandoc paths
russHyde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Package: tfpscanner | ||
Title: Transmission fitness polymorphism scanner | ||
Version: 0.2.1 | ||
Date: 2022-12-06 | ||
Version: 0.2.2 | ||
Date: 2023-01-18 | ||
Author: Erik Volz, Olivia Boyd | ||
Maintainer: Erik Volz <[email protected]> | ||
Description: A pipeline for scanning a SARS-CoV-2 phylogeny for clades with outlying growth | ||
|
@@ -16,7 +16,7 @@ Imports: | |
ggplot2, | ||
ggtree, | ||
glue, | ||
htmlwidgets, | ||
htmlwidgets (>= 1.6.0), | ||
knitr, | ||
lubridate, | ||
mgcv, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests have been constructed so that they look virtually identical. They could reasonably be rewritten as a single testthat block parameterised by the different arguments to
save_trees
using {patrick}. Adding the extra dependency seemed over the top to reduce 4 simple tests to 1, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to have a little duplication to avoid extra dependencies