fix zsh $+commands[perl] syntax does not work with setopt ksh_arrays

[lincheney]

When setopt ksh_arrays in zsh, the syntax $+commands[perl] doesn't work properly and gives a syntax warning saying fzf-history-widget:6: bad output format specification

I think the everything else still actually works, just the warning is a bit annoying.

I have setopt ksh_arrays set in my zshrc.

[LangLangBart]

Thank you again¹.

DESCRIPTION OF OPTIONS
  In the following list, options set by default in all emulations are marked <D>; those set by
  default  only  in csh, ksh, sh, or zsh emulations are marked <C>, <K>, <S>, <Z> as appropri-
  ate. 

KSH_ARRAYS <K> <S>
  Emulate ksh array handling as closely as possible.  If this option is set, array ele-
  ments  are  numbered  from  zero,  an array parameter without subscript refers to the
  first element instead of the whole array, and braces are required to delimit  a  sub-
  script (`${path[2]}' rather than just `$path[2]') or to apply modifiers to any param-
  eter (`${PWD:h}' rather than `$PWD:h').

I always feel bad about such mistakes because they are preventable.

Given that the original message was deleted and we no longer have the details
about why emulate -LR zsh failed for a user², should we reintroduce the
command and find out?

EDIT: The question was mainly for the maintainer, but feedback
from the issue author is also welcome.

Footnotes

1. fix zsh ${(@)history} syntax does not work with ksh_arrays by lincheney · Pull Request #3893 · junegunn/fzf · GitHub ↩

2. [zsh] emulate -L zsh to avoid issues with incompatible options · junegunn/fzf@3a6af27 · GitHub ↩

[junegunn]

Given that the original message was deleted and we no longer have the details
about why emulate -LR zsh failed for a user2, should we reintroduce the
command and find out?

It was a long time ago and I don't really remember the details. I'd like to keep the change small for now and release a new patch version soon because this can be seen as a regression in 0.56.1.

[LangLangBart]

Approved.

[junegunn]

Thanks @lincheney for the patch. And thanks @LangLangBart for the review.