Support some level of parallelization in junit-vintage-engine #4135
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
marcphilipp
reviewed
Nov 19, 2024
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Outdated
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Outdated
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Outdated
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Outdated
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Show resolved
Hide resolved
junit-vintage-engine/src/main/java/org/junit/vintage/engine/VintageTestEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: yongjunhong <[email protected]>
YongGoose
force-pushed
the
feature/support-parallelization-in-junit-vintage-engine
branch
from
c25db8c
to
e12b155
Compare
marcphilipp
reviewed
Nov 25, 2024
Comment on lines
137
to
147
| try { | ||
| executorService.shutdown(); | ||
| if (!executorService.awaitTermination(SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS)) { | ||
| logger.warn(() -> "Executor service did not terminate within the specified timeout"); | ||
| executorService.shutdownNow(); | ||
| } | ||
| } | ||
| catch (InterruptedException e) { | ||
| logger.warn(e, () -> "Interruption while waiting for executor service to shut down"); | ||
| Thread.currentThread().interrupt(); | ||
| } |
There was a problem hiding this comment.
Can we extract this into a separate method to improve readability?
There was a problem hiding this comment.
Great idea!
I worked on this in the commit 96b31e0
Issue: junit-team#3717 Signed-off-by: yongjunhong <[email protected]>
|
If the parallelization work is completed, I would appreciate it if you could take a look at the Open Question in the PR description 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #2229
This PR implements parallel execution support for the JUnit Vintage engine, addressing issue #2229.
concurrent executionof test descriptors when parallel execution is enabled.planned)Open Question
I haven’t yet worked on the part that handles reading configuration parameters, such as whether
parallel executionshould be enabled or the number of threads to be used.Is there a specific configuration format or approach you would recommend for this?
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations