fix #217

junstyle · Aug 14, 2024 · 165774b · 165774b
1 parent 21a0323
commit 165774b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/index.js b/index.js
@@ -18265,9 +18265,6 @@ function runAsync(command, args, options, onData = null) {
       if (command.includes(" ") && command[0] != '"') {
         command = '"' + command + '"';
       }
-      for (let i = 0; i < args.length; i++) {
-        args[i] = args[i].replace(/"/g, '\\"');
-      }
     }
     output("runAsync: spawn " + command);
     output(JSON.stringify(args, null, 2));
@@ -18458,7 +18455,7 @@ var PHPCSFixer = class extends PHPCSFixerConfig {
       }
     }
     if (!useConfig && this.rules) {
-      args.push("--rules=" + this.rules);
+      args.push('--rules="' + this.rules.replace(/"/g, '\\"') + '"');
     }
     if (this.allowRisky) {
       args.push("--allow-risky=yes");

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "php-cs-fixer",
   "displayName": "php cs fixer",
   "description": "PHP CS Fixer extension for VS Code, php formatter, php code beautify tool, format html",
-  "version": "0.3.16",
+  "version": "0.3.17",
   "publisher": "junstyle",
   "author": "junstyle",
   "license": "ISC",

diff --git a/src/index.ts b/src/index.ts
@@ -152,7 +152,7 @@ class PHPCSFixer extends PHPCSFixerConfig {
       }
     }
     if (!useConfig && this.rules) {
-      args.push('--rules=' + this.rules)
+      args.push('--rules="' + (this.rules as string).replace(/"/g, "\\\"") + '"')
     }
     if (this.allowRisky) {
       args.push('--allow-risky=yes')

diff --git a/src/runAsync.ts b/src/runAsync.ts
@@ -9,9 +9,6 @@ export function runAsync(command: string, args: string[], options: SpawnOptionsW
       if (command.includes(" ") && command[0] != '"') {
         command = '"' + command + '"'
       }
-      for (let i = 0; i < args.length; i++) {
-        args[i] = args[i].replace(/"/g, "\\\"")
-      }
     }
 
     output('runAsync: spawn ' + command);