Minimum upgrade to async-capable rust-cuda v2 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some progress Further async integration progress, rustcoalescence fails to compile Some progress with dispatch coersion Small cleanup Cleanup cuda algorithm coersion Some more cleanup Add back missing Backup for SeaHash and WyHash rngs Fix CUDA kernel extraneous pub exports Minor improvement of the event buffer hack Remove unused control_flow_enum feature Revert Copy for [Indexed]Location Revert new clone Update to rust-cuda with async kernel launch async return Update to latest rust-cuda Fix rustfmt Temporary fix to allow CUDA algorithm linking Small cleanup, mostly of unused clippy allows Small improvement to CUDA EventBuffer Try trait-based kernel signature check Update rust-toolchain Fix clippy lints Try with const match instead Try with memcmp intrinsic Try out experimental const-type-layout with compression Try interning all const layout strings Try check Try check again
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 16.34% 16.23% -0.12%
==========================================
Files 293 289 -4
Lines 20973 20586 -387
==========================================
- Hits 3429 3343 -86
+ Misses 17544 17243 -301 ☔ View full report in Codecov by Sentry. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #230 (too widely scoped) and #271 (for easier rebases). Also, this PR is no longer blocked on #79.
This PR upgrades
rust-cudato the latest version which has simplified and improved the PTX kernel API, added support for async kernel execution and memory transfers, and fixed some memory safety issues.