Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultarray for LabeledValue and apply_value_labels option #28

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

junyuan-chen
Copy link
Owner

@junyuan-chen junyuan-chen commented Jun 28, 2023

Missing methods are added in order to allow vcat to work when a DataFrame contains LabeledArrays (fixes #27).

In addition, readstat now accepts a Boolean keyword argument apply_value_labels to control whether value labels should be applied to columns. At this moment, setting apply_value_labels to false simply removes the column metadata that indicate the names of value labels. This is the simplest way to resolve #25, but has the downside of not showing how value labels are originally assigned in the data file.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #28 (bcf53d0) into main (6377295) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          10       10           
  Lines        1158     1181   +23     
=======================================
+ Hits         1157     1180   +23     
  Misses          1        1           
Impacted Files Coverage Δ
src/ReadStatTables.jl 100.00% <ø> (ø)
src/LabeledArrays.jl 100.00% <100.00%> (ø)
src/readstat.jl 99.21% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing DataAPI.defaultarray support loading data without labels?
1 participant