Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Contributing a new features to MyST (roles & transforms) #987

Merged
merged 17 commits into from
Mar 22, 2024

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Mar 14, 2024

This PR will eventually add a new page to our documentation, that intends to act as a "ten minute guide to adding new features to MyST". It will overlap with the plugins page slightly, but I hope that it will bootstrap some of the contribution questions.

@agoose77 agoose77 self-assigned this Mar 14, 2024
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited about this - thanks for getting it started @agoose77!

@agoose77
Copy link
Contributor Author

@rowanc1 I think this is ready for a review pass. I'm sure it's not perfect, but I'd benefit from a fresh pair of eyes 🙏

@agoose77 agoose77 marked this pull request as ready for review March 15, 2024 18:34
Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding to this PR how to add a frontmatter option, or should it be added in another tutorial? The frontmatter option seems quite a bit more convoluted to document.

docs/contribute-add-feature.md Show resolved Hide resolved
docs/contribute-add-feature.md Outdated Show resolved Hide resolved
@agoose77
Copy link
Contributor Author

Do you think it's worth adding to this PR how to add a frontmatter option, or should it be added in another tutorial? The frontmatter option seems quite a bit more convoluted to document.

Hmm, it's a tricky balance between covering "enough" and "too much". I want to keep this tutorial / guide small enough that someone could feel brave enough to get started. I think we might need more guides to help cover the wider challenges with contribution.

@LecrisUT
Copy link
Contributor

Do you think it's worth adding to this PR how to add a frontmatter option, or should it be added in another tutorial? The frontmatter option seems quite a bit more convoluted to document.

Hmm, it's a tricky balance between covering "enough" and "too much". I want to keep this tutorial / guide small enough that someone could feel brave enough to get started. I think we might need more guides to help cover the wider challenges with contribution.

Indeed, I probably confused role with directive, so adding those parts to this documentation, would be a bit too much. Maybe the directive can be intuited a bit after this guide, but frontmatter seems to be more complicated, e.g. my attempts at navigating #979. Worth having an example for that imo.

@rowanc1
Copy link
Member

rowanc1 commented Mar 22, 2024

I have gone through this and updated a few things!

This is great @agoose77 and I think ready to be merged. I changed it so we transform the wordCount node to a text node so that the final picture is complete. There can be another tutorial in the future on how to add a new renderer.

@rowanc1 rowanc1 changed the title DOCS: write-up the process of adding new features to MyST 📖 Contributing a new features to MyST (roles & transforms) Mar 22, 2024
@rowanc1 rowanc1 merged commit 2b4f850 into main Mar 22, 2024
4 checks passed
@rowanc1 rowanc1 deleted the agoose77/docs-adding-new-feature branch March 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants