-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Contributing a new features to MyST (roles & transforms) #987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited about this - thanks for getting it started @agoose77!
@rowanc1 I think this is ready for a review pass. I'm sure it's not perfect, but I'd benefit from a fresh pair of eyes 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth adding to this PR how to add a frontmatter
option, or should it be added in another tutorial? The frontmatter
option seems quite a bit more convoluted to document.
Hmm, it's a tricky balance between covering "enough" and "too much". I want to keep this tutorial / guide small enough that someone could feel brave enough to get started. I think we might need more guides to help cover the wider challenges with contribution. |
Indeed, I probably confused |
I have gone through this and updated a few things! This is great @agoose77 and I think ready to be merged. I changed it so we transform the |
This PR will eventually add a new page to our documentation, that intends to act as a "ten minute guide to adding new features to MyST". It will overlap with the plugins page slightly, but I hope that it will bootstrap some of the contribution questions.