Skip to content

Support ServiceManagerPlugin #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Support ServiceManagerPlugin #7616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/index.template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import { PageConfig, URLExt } from '@jupyterlab/coreutils';

import { PluginRegistry } from '@lumino/coreutils';

require('./style.js');
require('./extraStyle.js');

Expand Down Expand Up @@ -213,10 +215,20 @@ async function main() {
// plugin even if the debugger is only loaded on the notebook page.
PageConfig.setOption('allPlugins', '{{{ json notebook_plugins }}}');


const pluginRegistry = new PluginRegistry();
const NotebookApp = require('@jupyter-notebook/application').NotebookApp;
const app = new NotebookApp({ mimeExtensions, availablePlugins });

app.registerPluginModules(mods);
pluginRegistry.registerPlugins(mods);
const IServiceManager = require('@jupyterlab/services').IServiceManager;
const serviceManager = await pluginRegistry.resolveRequiredService(IServiceManager);

const app = new NotebookApp({
pluginRegistry,
serviceManager,
mimeExtensions,
availablePlugins
});

// Expose global app instance when in dev mode or when toggled explicitly.
const exposeAppInBrowser =
Expand Down
3 changes: 3 additions & 0 deletions app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
"@jupyterlab/pdf-extension": "~4.4.0-beta.2",
"@jupyterlab/pluginmanager-extension": "~4.4.0-beta.2",
"@jupyterlab/running-extension": "~4.4.0-beta.2",
"@jupyterlab/services-extension": "~4.4.0-beta.2",
"@jupyterlab/settingeditor": "~4.4.0-beta.2",
"@jupyterlab/settingeditor-extension": "~4.4.0-beta.2",
"@jupyterlab/shortcuts-extension": "~5.2.0-beta.2",
Expand All @@ -181,6 +182,7 @@
"@jupyterlab/translation-extension": "~4.4.0-beta.2",
"@jupyterlab/ui-components-extension": "~4.4.0-beta.2",
"@jupyterlab/vega5-extension": "~4.4.0-beta.2",
"@lumino/coreutils": "~2.2.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"yjs": "^13.5.40"
Expand Down Expand Up @@ -296,6 +298,7 @@
"@jupyterlab/notebook-extension:widget-factory"
],
"@jupyterlab/pluginmanager-extension": true,
"@jupyterlab/services-extension": true,
"@jupyterlab/shortcuts-extension": true,
"@jupyterlab/terminal-extension": true,
"@jupyterlab/theme-light-extension": true,
Expand Down
14 changes: 13 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2179,6 +2179,7 @@ __metadata:
"@jupyterlab/pdf-extension": ~4.4.0-beta.2
"@jupyterlab/pluginmanager-extension": ~4.4.0-beta.2
"@jupyterlab/running-extension": ~4.4.0-beta.2
"@jupyterlab/services-extension": ~4.4.0-beta.2
"@jupyterlab/settingeditor": ~4.4.0-beta.2
"@jupyterlab/settingeditor-extension": ~4.4.0-beta.2
"@jupyterlab/shortcuts-extension": ~5.2.0-beta.2
Expand All @@ -2191,6 +2192,7 @@ __metadata:
"@jupyterlab/translation-extension": ~4.4.0-beta.2
"@jupyterlab/ui-components-extension": ~4.4.0-beta.2
"@jupyterlab/vega5-extension": ~4.4.0-beta.2
"@lumino/coreutils": ~2.2.0
"@types/rimraf": ^3.0.2
css-loader: ~5.0.1
extra-watch-webpack-plugin: ^1.0.3
Expand Down Expand Up @@ -4454,6 +4456,16 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlab/services-extension@npm:~4.4.0-beta.2":
version: 4.4.0-beta.2
resolution: "@jupyterlab/services-extension@npm:4.4.0-beta.2"
dependencies:
"@jupyterlab/services": ^7.4.0-beta.2
"@lumino/coreutils": ^2.2.0
checksum: bdc141b91af525ec33cfa6f767a93e3cd6c0663afc65314e262779501a66e4cbba56a523e168916d5aab39daa6c92b406e773a68a91f9c451d4aedc954172084
languageName: node
linkType: hard

"@jupyterlab/services@npm:^7.3.4":
version: 7.3.4
resolution: "@jupyterlab/services@npm:7.3.4"
Expand Down Expand Up @@ -5281,7 +5293,7 @@ __metadata:
languageName: node
linkType: hard

"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.2.0, @lumino/coreutils@npm:^2.2.0":
"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.2.0, @lumino/coreutils@npm:^2.2.0, @lumino/coreutils@npm:~2.2.0":
version: 2.2.0
resolution: "@lumino/coreutils@npm:2.2.0"
dependencies:
Expand Down
Loading