Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curvenote: add to federation! #2846

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

manics
Copy link
Member

@manics manics commented Nov 30, 2023

Add to mybinder.org, weight 1

@manics manics merged commit 539dcc4 into jupyterhub:main Nov 30, 2023
6 checks passed
@manics manics deleted the aws-curvenote-binder branch November 30, 2023 23:09
@minrk
Copy link
Member

minrk commented Dec 1, 2023

Hooray! Seems to be working, but it doesn't seem to get ~any traffic (I found a couple in the redirect logs). Maybe bump weight to 10?

A weight of 1 means it will only get assigned on average one repo out of 201 (not 0.5% of builds, could be far less or far more than that), and we don't build all that many unique repos.

Our redirect logic favoring a specific repo->member doesn't give us a good way to distribute load smoothly, because a small number of repos usually represent a very large fraction of load at any given time, meaning that our load is very rarely evenly distributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants