Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cryptnono container lookup config into individual deployments #2882

Merged
merged 1 commit into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/curvenote.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ binderhub:
cryptnono:
enabled: true
priorityClassName: binderhub-core
detectors:
execwhacker:
containerdHostPath: /run/containerd
dockerHostPath: /run/dind

grafana:
enabled: false
Expand Down
7 changes: 7 additions & 0 deletions config/ovh2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ binderhub:
imageGCThresholdLow: 30e9
imageGCThresholdType: "absolute"

cryptnono:
detectors:
execwhacker:
containerdHostPath: /run/containerd
# TODO: Currently disabled as isn't present on all nodes, only on nodes running builders
# dockerHostPath: /run/dind

grafana:
nodeSelector: *coreNodeSelector
ingress:
Expand Down
5 changes: 3 additions & 2 deletions mybinder/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ cryptnono:
execwhacker:
metrics:
enabled: true
containerdHostPath: /run/containerd
# TODO: Currently disabled as isn't present on all nodes, only on nodes running builders
# execwhacker needs access to containerd, and docker on build hosts, to lookup the container.
# Set these in the configurations for each deployment
# containerdHostPath: /run/containerd
# dockerHostPath: /run/dind

imagePullSecrets:
Expand Down