Skip to content

Commit

Permalink
Remove unused _urlopen method
Browse files Browse the repository at this point in the history
This was never used anywhere, and actually didn't even import -
'request' is actually urllib.request, not requests. It
was never imported but used here!
  • Loading branch information
yuvipanda committed Dec 20, 2024
1 parent b7c1515 commit e463ca9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
13 changes: 0 additions & 13 deletions repo2docker/contentproviders/doi.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@ def _request(self, url, **kwargs):

urlopen = _request

def _urlopen(self, req, headers=None):
"""A urlopen() helper"""
# someone passed a string, not a request
if not isinstance(req, request.Request):
req = request.Request(req)

req.add_header("User-Agent", f"repo2docker {__version__}")
if headers is not None:
for key, value in headers.items():
req.add_header(key, value)

return request.urlopen(req)

def doi2url(self, doi):
# Transform a DOI to a URL
# If not a doi, assume we have a URL and return
Expand Down
1 change: 0 additions & 1 deletion tests/unit/contentproviders/test_figshare.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def test_fetch_zip(requests_mock):
)
requests_mock.get(f"file://{fig_path}", content=open(fig_path, "rb").read())

# with patch.object(Figshare, "urlopen", new=mock_urlopen):
with TemporaryDirectory() as d:
output = []
for l in test_fig.fetch(test_spec, d):
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/contentproviders/test_swhid.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ def test_detect(swhid, expected):
assert provider.detect(swhid) == expected


def fake_urlopen(req):
print(req)
return req.headers


def test_unresolving_swhid():
provider = Swhid()
Expand Down

0 comments on commit e463ca9

Please sign in to comment.