r: Bump version of rsession-proxy #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If memory serves me right, the specific version semantics were here because at some point we were installing different versions of rsession-proxy for different versions of R. We don't do that anymore, so we should just unpin it and let the pip solver install the appropriate version. Hopefully fixes https://discourse.jupyter.org/t/r-conda-example-repo-isnt-working-any-more/21739/3
fomightez
added a commit
to fomightez/rcondatestOct
that referenced
this pull request
Oct 12, 2023
|
I think we're pinning everything else that's installed by default in r2d. Is there anyway we can move this to a requirements.txt file that can be bumped by dependabot (or the freeze.py script, though dependabot is easier)? |
We can move to a proper pinning setup later
|
@manics I've instead just bumped the version number to latest to minimize the amount of changes we need to (hopefully?) fix the current issue. Given I'm trying to focus on the frontend on binderhub, I don't think I currently have time to move things to a requirements.txt. I hope this is acceptable instead. |
yuvipanda
changed the title
manics
approved these changes
Oct 12, 2023
|
Thanks, @manics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes https://discourse.jupyter.org/t/r-conda-example-repo-isnt-working-any-more/21739/3