Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pytest=8 #1330

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Support pytest=8 #1330

merged 4 commits into from
Feb 2, 2024

Conversation

manics
Copy link
Member

@manics manics commented Jan 28, 2024

pytest 8 breaks our tests:

ERROR tests/base/node - pytest.PytestRemovedIn8Warning: The (fspath: py.path.local) argument to LocalRepo is deprecated. Please use the (path: pathlib.Path) argument instead.
See https://docs.pytest.org/en/latest/deprecations.html#fspath-argument-for-node-constructors-replaced-with-pathlib-path

Reported in #1329 (comment)

@manics manics added the ci label Jan 28, 2024
@manics manics changed the title Pin pytest<8 Support pytest=8 Jan 28, 2024
@@ -2,6 +2,6 @@ build
conda-lock
pre-commit
pytest-cov
pytest>=4.6
pytest>=7,<9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preemptively blocking pytest 9? Are there known planned incompatibilities to deal with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing known, I'm just fed up of dealing with random breakages! Do you want me to remove the upper limit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I think we should remove the limit as otherwise we may get stuck here. In general I think all upper limit pins should come with a time expiry.

Otherwise happy to merge this.

dev-requirements.txt Outdated Show resolved Hide resolved
@yuvipanda
Copy link
Collaborator

The test failure is real but unrelated:

1: package ‘IRkernel’ is not available (for R version 3.6.3)

So I'm going to merge this.

@yuvipanda yuvipanda merged commit 3221560 into jupyterhub:main Feb 2, 2024
17 of 18 checks passed
@manics manics deleted the pin-pytest branch February 2, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants