-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pytest=8 #1330
Support pytest=8 #1330
Conversation
dev-requirements.txt
Outdated
@@ -2,6 +2,6 @@ build | |||
conda-lock | |||
pre-commit | |||
pytest-cov | |||
pytest>=4.6 | |||
pytest>=7,<9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preemptively blocking pytest 9? Are there known planned incompatibilities to deal with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing known, I'm just fed up of dealing with random breakages! Do you want me to remove the upper limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, I think we should remove the limit as otherwise we may get stuck here. In general I think all upper limit pins should come with a time expiry.
Otherwise happy to merge this.
The test failure is real but unrelated:
So I'm going to merge this. |
pytest 8 breaks our tests:
Reported in #1329 (comment)