Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use self.log.warning instead of warnings.warn #1384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use self.log.warning instead of warnings.warn #1384

wants to merge 1 commit into from

Conversation

yuvipanda
Copy link
Collaborator

warnings.warn sidesteps all the json logging bits we do, and repo2docker will produce non-json output that binderhub then struggles to consume.

@yuvipanda
Use self.log.warning instead of warnings.warn
1ae5a20 
warnings.warn sidesteps all the json logging bits we do,
and repo2docker will produce non-json output that binderhub
then struggles to consume.
@yuvipanda yuvipanda requested review from minrk and manics and removed request for minrk December 8, 2024 08:23
@yuvipanda
Copy link
Collaborator Author

failed: Error during build: Expecting value: line 1 column 1 (char 0)unknown: Exception ignored in: <function Application.__del__ at 0x105855300> is what I get without this from binderhub

@yuvipanda
Copy link
Collaborator Author

Hmm, so the errors aren't actually coming from this - they're coming from somewhere else. Debugging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics Awaiting requested review from manics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuvipanda