Fix cpu and memory config validation in JSON schema
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrdnbradford
changed the title
cpu validation in JSON schemacpu config validation in JSON schema
minrk
reviewed
Nov 14, 2024
jrdnbradford
changed the title
cpu config validation in JSON schemacpu and memory config validation in JSON schema
|
I went ahead and fixed the similar issue with the memory limit, which should also allow |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1012.
The config schema for
cpulimits now accepts values such as3,3.5and"None". Addedminimums of0to prevent negative numerics.Details on
numbercan be found in the JSON Schema docs.