Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to traefik example #260

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

matuzalemmuller
Copy link
Contributor

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manics manics merged commit f60ce12 into jupyterhub:main Nov 6, 2024
2 checks passed
@minrk
Copy link
Member

minrk commented Nov 6, 2024

Sorry, should have responded quicker. This updates the link to a file that exists, but the description is not of that file. The fix should have been to create the missing file (perhaps someone forgot a git add), not update the link to a different file.

@minrk
Copy link
Member

minrk commented Nov 6, 2024

That someone was me! #261

@matuzalemmuller
Copy link
Contributor Author

Ah, apologies. Didn’t realize it was the wrong file. Thanks for fixing it so quickly.

@minrk
Copy link
Member

minrk commented Nov 7, 2024

No problem, thanks for noticing and submitting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants