add dialog checkbox to include token in URL

[minrk]

This could be considered a solution to #54, though it's the simplest possible one (no settings or server-side override).

• adds checkbox to toggle whether share URLs have the token embedded. This is per-dialog and off by default, so to preserve current behavior requires an extra click, which feels appropriate to me given the consequences of sharing a link with credentials
• Updates messages for with/without token and further clarification in JupyterHub context
• only shows the checkbox if there's a token to be shared (e.g. in local jupyter with a password, there is no token to share)
• There's a weird CSS jump as the dialog changes sizes when the message changes. I'm not sure how best to fix that.

There are lots of other ways to address #54 in terms of UX - where/when/who picks which link(s) to share. This is just one option.

In action:

Screen.Recording.2023-02-10.at.10.45.12.mov

Extra bit: I had to bump tsconfig target to es2018 to get it to build for some error with AsyncIterator. I'm not sure why since I didn't change any dependencies.

[jtpio]

Thanks @minrk for this.

Looks like CI is failing due to a lint issue.

[jtpio]

Extra bit: I had to bump tsconfig target to es2018 to get it to build for some error with AsyncIterator. I'm not sure why since I didn't change any dependencies.

Right this seems to be an issue with JupyterLab 3.6 (jupyterlab/jupyterlab#14029).

[minrk]

Sorry for dropping off. Fixed lint.

[jtpio]

There's a weird CSS jump as the dialog changes sizes when the message changes. I'm not sure how best to fix that.

It's probably ok for now. We can always track this in a separate issue to iterate on it.

[jtpio]

Just tried with the Binder for this PR: https://mybinder.org/v2/gh/minrk/jupyterlab-link-share/include-token-checkbox

And it looks like the token is not included after enabling the checkbox and clicking on Copy Link:

include-token-url.mp4

Although it shows up correctly in the dialog, probably just an issue when copying to the clipboard.

[jtpio]

Thanks!

[jtpio]

New release with this change: https://github.com/jupyterlab-contrib/jupyterlab-link-share/releases/tag/v0.3.0