Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: David Brochart <[email protected]>
  • Loading branch information
trungleduc and davidbrochart authored Dec 18, 2024
1 parent 587a496 commit 31679b6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ async def put(self, root_roomid):
root_room = await self._websocket_server.get_room(root_roomid)
except RoomNotFound:
self.set_status(404)
return self.finish({"code": 404, "error": "Room not found"})
return self.finish({"code": 404, "error": "Root room not found"})

update = root_room.ydoc.get_update()
fork_ydoc = Doc()
Expand Down Expand Up @@ -684,7 +684,7 @@ async def delete(self, fork_roomid):
fork_info = FORK_ROOMS.get(fork_roomid, None)
if fork_info is None:
self.set_status(404)
return self.finish({"code": 404, "error": "Fork room does not exist"})
return self.finish({"code": 404, "error": "Fork room not found"})
root_roomid = fork_info["root_roomid"]
del FORK_ROOMS[fork_roomid]
if self.get_query_argument("merge") == "true":
Expand Down

0 comments on commit 31679b6

Please sign in to comment.