Update event schema version type #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It looks like UI tests are flaky again @trungleduc?
|
|
yeah, your only choice is to relax the diff ratio |
trungleduc
reviewed
Dec 18, 2024
| @@ -20,7 +20,7 @@ module.exports = { | |||
| }, | |||
| expect: { | |||
| toMatchSnapshot: { | |||
| maxDiffPixelRatio: 0.0001 | |||
| maxDiffPixelRatio: 0.01 | |||
There was a problem hiding this comment.
Suggested change
| maxDiffPixelRatio: 0.01 | |
| maxDiffPixelRatio: 0.001 |
1% might be overkill
There was a problem hiding this comment.
It was not, I'm reverting that change.
Co-authored-by: Duc Trung Le <[email protected]>
|
Ubuntu test failures are tracked in #416. |
Should be fixed in 15 minutes with release of 4.3.4 🤞 |
|
Oh, let's wait for it then 👍 |
|
Let's see if it picks up JupyterLab v4.3.4. |
|
CI is green again 🎉 |
andrii-i
pushed a commit
to andrii-i/jupyter-collaboration
that referenced
this pull request
Feb 11, 2025
* Update event schema version type * Tweak maxDiffPixelRatio * Set maxDiffPixelRatio to 0.001 Co-authored-by: Duc Trung Le <[email protected]> * Set maxDiffPixelRatio to 0.01 --------- Co-authored-by: Duc Trung Le <[email protected]>
andrii-i
pushed a commit
to andrii-i/jupyter-collaboration
that referenced
this pull request
Feb 11, 2025
* Update event schema version type * Tweak maxDiffPixelRatio * Set maxDiffPixelRatio to 0.001 Co-authored-by: Duc Trung Le <[email protected]> * Set maxDiffPixelRatio to 0.01 --------- Co-authored-by: Duc Trung Le <[email protected]>
|
@meeseeksdev please backport to 3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-collaboration
that referenced
this pull request
Feb 12, 2025
davidbrochart
added a commit
that referenced
this pull request
Feb 12, 2025
* Backport PR #421: Update event schema version type * Bump jupyter_server to >=2.15.0<3.0.0 --------- Co-authored-by: David Brochart <[email protected]> Co-authored-by: Nicolas Brichet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.