Support for keyboard layouts. #17378
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJSF has support for field and widget renderers, and so does the editor registry, but we don't currently pass them from one to the other in the settings form. This bridges that gap.
This caused setting with undefined defaults to not be saved.
Some form controls can benefit from taking advantage of all the space available, so make sure they can.
Initial implementation of keyboard layout support. Based on a WIP branch in lumino, so will likely be unstable until that is approved and released (if it will).
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:shortcuts
pkg:settingeditor
pkg:ui-components
tag:CSS
|
Note: currently I've also added support for this experimental Web API for demonstration purposes, but the feature does not rely on that. It only makes things more convenient in browsers that support it. |
vidartf
added
enhancement
tag:Settings
feature
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #17355.
Resolves #7579.
Code changes
Adds a new plugin in the shortcuts-extension package. Relies on the WIP lumino branch in this PR jupyterlab/lumino#291 .
User-facing changes
ækey, it will only trigger if I push a button that produces that character (e.g. I have a Norwegian keyboard and press thecode=Quotebutton, or if I have a Danish keyboard and press thecode=Semicolonbutton). Non-QWERTY can also be configured (AZERTY, Dvorak, etc).Backwards-incompatible changes
Not sure if it qualifies as backwards-incompatible, but the shortcut-extension package will require a dependency on an as-yet unreleased feature in the Lumino "keyboard" package.