Update for kernel 4.13 #83
Conversation
Thanks to CONFIG_FORTIFY_SOURCE, the compiler refused to compile this buggy code. See https://outflux.net/blog/archives/2017/09/05/security-things-in-linux-v4-13/ for details why this issue hasn't been noticed before kernel 4.13. Fixes jurobystricky#81.
|
this does not work for me, i get further in the build progress but it halts here:
Edit: saw that you mentioned that you need fix #77 as well. Please referece this in your pull request. |
|
Using I cloned it and applied #77 (I think) I just updated to 4.13.9-200.fc26.x86_64 and while, after remake/depmod/reboot, the wlan0 appears but, it is never able to connect to my router (WNDR4000). I booted to 4.13.5 and it is working again. Cursory look at the log tells me nothing |
What do you mean? I don't understand. Can you please give me a line number?
Same here, which warning do you mean? Can you please use the code blocks around logging output? Your driver does not work in 4.13.9, but it works fine in 4.13.5? Are there any warnings during compilation (except the one about
Have you tried looking at |
|
First, I was mistaken about wlan0 being available on 13.9.
|
|
Here is a dmesg, scrap, from a working boot 13.5 |
|
Oddly enough, Here is a dmesg, scrap, from a failed boot 13.5 |
|
Sorry about the code segments |
|
@dsime42 : Can you please open a separate bug report? Thanks! Btw: EOLs don't disappear if you are using the triple And it would be easier to read if you didn't abbreviate 4.13.9 to 13.9 etc. |
|
Sureand thanks for the '''I was just using the "code" button to drop it in
From: Christian Stadelmann <[email protected]>
To: jurobystricky/Netgear-A6210 <[email protected]>
Cc: dsime42 <[email protected]>; Mention <[email protected]>
Sent: Wednesday, November 1, 2017 4:08 PM
Subject: Re: [jurobystricky/Netgear-A6210] Update for kernel 4.13 (#83)
@dsime42 : Can you please open a separate bug report? Thanks!Btw: EOLs don't disappear if you are using the triple ```.And it would be easier to read if you didn't abbreviate 4.13.9 to 13.9 etc.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@genodeftest |
|
I'm building OK on 4.13.0 with the memcpy fix, plus a fix to the signature of add and change flags. Happy to share my patch and/or submit a fresh PR if anyone has any problems building still. |
|
@mattgodbolt : I'm interested in your patch, preferably onto my port-to-4.13 branch. Btw: Are you interested in creating a GitHub "organisation" for this driver and managing future development? |
|
Hi, I found an issue opened in this project but I do not understand how to solve. and no other information [ 527.228301] usb 4-5: new SuperSpeed USB device number 6 using xhci_hcd [ 527.319199] driver version: 3.0.0.1 (Apr 11 2018 00:19:48) . |
|
@abdujaparov It is interesting that it was your modem manager that segfaulted. Did you look for that error on the net? |
Thanks to CONFIG_FORTIFY_SOURCE, the compiler refused to compile this buggy code.
See https://outflux.net/blog/archives/2017/09/05/security-things-in-linux-v4-13/
for details why this issue hasn't been noticed before kernel 4.13.
Fixes #81.
Note that #82 still should be fixed before running this driver on kernel 4.13.
Edit:
If you want to run this module on kernel 4.13, please check out my port-to-4.13 branch instead, which also includes fixes for kernel 4.12.