Final config for use with DDEV v1.23.1, replaces #30, replaces #23 #31
Conversation
There was a problem hiding this comment.
I manually tested this and it's in the opinionated sqlite3 setup right now, works without mariadb (and doesn't accidentally use mariadb).
If you'd be willing to get this in @justafish I'll attempt to make drush and mariadb work before Drupalcon.
| ARG TARGETPLATFORM | ||
|
|
There was a problem hiding this comment.
DDEV v1.23.1 will have sqlite3 3.45.1 (but only for Drupal 11). This is already in HEAD.
|
Sorry that I disrupted the previous PR. Just confirming this PR has had a lot of eyeballs and should be pretty straightforward - good to see that sqlite won't be needed but i assume as it currently stands this won't be fully testable? |
|
This is fully testable and has automated tests working. The test instructions are above. |
This is part of justafish#31 Rebase will be required when that goes in.
| @@ -23,7 +23,8 @@ | |||
| <!-- Do not limit the amount of memory tests take to run. --> | |||
| <ini name="memory_limit" value="-1"/> | |||
| <env name="SIMPLETEST_BASE_URL" value="DRUPAL_CORE_DDEV_URL"/> | |||
| <env name="SIMPLETEST_DB" value="mysql://db:db@db/db"/> | |||
| <!-- <env name="SIMPLETEST_DB" value="mysql://db:db@db/db"/> --> | |||
| <env name="SIMPLETEST_DB" value="sqlite://localhost/sites/default/files/db.sqlite"/> | |||
There was a problem hiding this comment.
🤔 do we really want this synced with mutagen and the like? What about storing in /tmp, or if it needs to be persistent in /home/<user>/...?
There was a problem hiding this comment.
Thanks for the review.
This is the traditional place for the sqlite file, Drupal core has used it for years.
On a normal DDEV macOS system, it would not be relavent to mutagen, since it would be bind-mounted with sites/default/files. However, with the current strategy here, ddev drupal believes drupal is installed if sites/default/files exists. But now with drush in #33 we won't have that problem as much.
IMO we should just leave it alone for now since it's the traditional location and in #34 we end up. being able to use mariadb or other traditional database types.
I'll also be doing a followup that uses tmpfs for mounting the mariadb, which is related to your persistence questions.
(Note that /home does not persist by default in a ddev-webserver environment though, but there are other options)
|
A few days ago the location/value of the sqlite3 packages changed, invalidating our install. However, DDEV v1.23.1 should be out this week, so as a result, rather than chasing this and duplicating effort, I've made this dependent on v1.23.1, so the tests likely won't pass. It can be updated when the new version comes out. |
rfay
changed the title
|
Thanks! |
This is part of justafish#31 Rebase will be required when that goes in.
This is part of justafish#31 Rebase will be required when that goes in.
This is part of justafish#31 Rebase will be required when that goes in.
@simesy gave me permission to push a replacement PR for his
This is exactly his #23 (before he pushed unrelated commits to his branch), rebased to current. #30 can be closed.
I will test this and make sure it can work at least as is.
Then if we can get it in I will try to make mariadb testing and drush install work.
This can be tested with