Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix at ExcelColor() and some minor refractor #321

Merged
merged 15 commits into from
Feb 7, 2024
Merged

Bug fix at ExcelColor() and some minor refractor #321

merged 15 commits into from
Feb 7, 2024

Conversation

devsdocs
Copy link
Contributor

@devsdocs devsdocs commented Feb 7, 2024 •
edited
Loading

  • Add test for color too

FauconSpartiate
FauconSpartiate approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FauconSpartiate FauconSpartiate merged commit 2e50109 into justkawal:main Feb 7, 2024
1 check passed
@devsdocs devsdocs deleted the Conflict branch February 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FauconSpartiate FauconSpartiate FauconSpartiate approved these changes

@justkawal justkawal Awaiting requested review from justkawal justkawal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsdocs @FauconSpartiate