Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added comments extraction from referenced excel sheet and sheet visibility #388

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rejero
Copy link

@rejero rejero commented Dec 6, 2024

  • Added functionality to retrieve comment from an excel file.
  • Added unit test for a sample excel with different comment conditions.

To access, simply assign a Data? object to a variable and access the comment (if it exists) with

  • .comment
    and it will return a String? consisting of the cell's comment.

Additional work to be done is to retrieve the comment's text styling as well, instead of a simple String.
More work can be done to test for any breaking conditions.

@rejero rejero requested a review from justkawal as a code owner December 6, 2024 09:39
@rejero rejero changed the title [Feature] Added comments extraction from referenced excel sheet Resolves #232: [Feature] Added comments extraction from referenced excel sheet Dec 7, 2024
@rejero rejero changed the title Resolves #232: [Feature] Added comments extraction from referenced excel sheet [Feature] Added comments extraction from referenced excel sheet Dec 7, 2024
@rejero
Copy link
Author

rejero commented Dec 7, 2024

Resolves #232

@rejero
Copy link
Author

rejero commented Dec 17, 2024

Added an additional commit that provides the visibility of sheets via excel.getSheetVisibility()
Resolves #241

@rejero rejero changed the title [Feature] Added comments extraction from referenced excel sheet [Feature] Added comments extraction from referenced excel sheet and sheet visibility Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant